Alon Bar-Lev has posted comments on this change.

Change subject: aaa: InternalAuthenticator should use the new extensions API
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.ovirt.org/#/c/26443/8/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java
File 
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java:

Line 44: 
Line 45:     private void doInit(ExtMap input, ExtMap output) {
Line 46:         context = input.<ExtMap> get(Base.InvokeKeys.CONTEXT);
Line 47:         context.mput(Base.ContextKeys.AUTHOR, "The oVirt Project").
Line 48:         mput(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS, 
"config.authn.user.password").
please do not replace, but append to this list of sensitive keys.
Line 49:         mput(Base.ContextKeys.EXTENSION_NAME, "Internal Authentication 
(Built-in").
Line 50:         mput(Base.ContextKeys.LICENSE, "ASL 2.0").
Line 51:         mput(Base.ContextKeys.HOME_URL, "http://www.ovirt.org";).
Line 52:         mput(Base.ContextKeys.VERSION, "N/A").


Line 52:         mput(Base.ContextKeys.VERSION, "N/A").
Line 53:         mput(Authn.ContextKeys.CAPABILITIES, 
Authn.Capabilities.AUTHENTICATE_PASSWORD);
Line 54:         Properties config = context.<Properties> 
get(Base.ContextKeys.CONFIGURATION);
Line 55:         adminUser = config.getProperty("config.authn.user.name");
Line 56:         adminPassword = context.<Properties> 
get(Base.ContextKeys.CONFIGURATION).getProperty("config.authn.user.password");
config.getProperty ?
Line 57: 
Line 58:     }
Line 59: 


-- 
To view, visit http://gerrit.ovirt.org/26443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to