Yair Zaslavsky has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the new API ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26443/6/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 50: mput(Base.ContextKeys.HOME_URL, "http://www.ovirt.org";). Line 51: mput(Base.ContextKeys.VERSION, "N/A"). Line 52: mput(Authn.ContextKeys.CAPABILITIES, Authn.Capabilities.AUTHENTICATE_PASSWORD); Line 53: Properties config = context.<Properties> get(Base.ContextKeys.CONFIGURATION); Line 54: config.put(Base.ConfigKeys.SENSITIVE_KEYS, "config.authn.user.password)"); > please add to list, do not overwrite. Can you change the key please? this is misleading. When I see Base.ConfigKeys I expect it to be set on config. Thanks! Line 55: adminUser = config.getProperty("config.authn.user.name"); Line 56: adminPassword = context.<Properties> get(Base.ContextKeys.CONFIGURATION).getProperty("config.authn.user.password"); Line 57: Line 58: } -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
