Moti Asayag has posted comments on this change.
Change subject: engine: clean up network monitoring code
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 906: Map<String, Integer> currVlans = new HashMap<String,
Integer>();
could you add a space line between ?
Line 971: (bond.get("cfg") instanceof Map) ? new
XmlRpcStruct((Map) bond.get("cfg")) : null;
you can add a type for the map, e.g.:
(bond.get("cfg") instanceof Map) ? new XmlRpcStruct((Map<String, Object>)
bond.get("cfg")) : null;
--
To view, visit http://gerrit.ovirt.org/4871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfbbbfb9c7c6020ea520a735eea1e847c5ae77c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
