Omer Frenkel has posted comments on this change.

Change subject: core, webadmin: remove name from template version
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/26270/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java:

Line 463:     @Override
Line 464:     protected void isSubTemplateEntityChanged() {
Line 465:         
getModel().getName().setIsChangable(!getModel().getIsSubTemplate().getEntity());
Line 466:         if (!getModel().getIsSubTemplate().getEntity()) {
Line 467:             getModel().getName().setEntity("");
> no need for //$NON-NLS-1$ ?
Done
Line 468:         } else {
Line 469:             // by default select the template of the vm
Line 470:             
getModel().getBaseTemplate().setEntity(getModel().getTemplate().getEntity());
Line 471: 


-- 
To view, visit http://gerrit.ovirt.org/26270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27f26e7d196d1d2eebfe86e8aac886f3e6a8fc5e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to