Arik Hadas has posted comments on this change. Change subject: core, webadmin: remove name from template version ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/26270/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java: Line 187: getModel().getTemplate().setSelectedItem(subVersions.get(1)); Line 188: } Line 189: } Line 190: Line 191: protected void isSubTemplateEntityChanged() { > 1. I agree regarding #1, what you're saying is also true for provisioning_SelectedItemChanged and it is abstract in this class, on the other hand, postOsItemChanged has a default empty implementation. so since there is no convention here, I agree that default-empty implementation is better in this case. Line 192: } Line 193: Line 194: public boolean validate() Line 195: { -- To view, visit http://gerrit.ovirt.org/26270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27f26e7d196d1d2eebfe86e8aac886f3e6a8fc5e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
