Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing changes to API (at domain groups/ids) ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/26191/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java: Line 12: Line 13: /** Line 14: * This is the identifier assigned by the engine to this group for internal use only. Line 15: */ Line 16: private Guid id = Guid.newGuid(); > Are you sure you want to do this? It means that any DbGroup instance will h Ok. Line 17: Line 18: /** Line 19: * This is the identifier assigned by the external directory to this group. Line 20: */ http://gerrit.ovirt.org/#/c/26191/10/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1735: <xs:complexContent> Line 1736: <xs:extension base="BaseResource"> Line 1737: <xs:sequence> Line 1738: <xs:element ref="domain" minOccurs="0"/> Line 1739: <xs:element name="domain_entry_id" type="xs:string" minOccurs="0" maxOccurs="1"/> > Shouldn't this be "domain_group_id"? Sorry, I would prefer to have one single term. I should fix the commit msg. Line 1740: <!-- used only to represent the initial role assignments for a Line 1741: new group, therafter modification of role assignments are Line 1742: only supported via the rel="roles" sub-collection --> Line 1743: <xs:element name="roles" type="Roles" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/26191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
