Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing changes to API (domain groups/ids) ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/26191/9/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/DirectoryEntryIdUtils.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/DirectoryEntryIdUtils.java: Line 1: package org.ovirt.engine.api.restapi.utils; Line 2: Line 3: import java.io.UnsupportedEncodingException; Line 4: Line 5: public class DirectoryEntryIdUtils { > I see that you these methods are inspired in the hex conversion methods of Ok, What do you think about using javax.xml.bind.DatatypeConverter instead of commons-codec? I Line 6: Line 7: public static String encode(String source) { Line 8: try { Line 9: byte[] bytes; -- To view, visit http://gerrit.ovirt.org/26191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
