Gilad Chaplik has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 14: (7 comments) removing -1, last touches and we're good to go. 2 general comments (other than small inline comments): * IMO no need for abstract class. NumaNode will be the host numa entity, and vNumaNode will inherit all its capabilities and add its own data (pinned, etc.) * need to decide on static/dynamic http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CpuStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CpuStatistics.java: Line 9: public class CpuStatistics implements Serializable { Line 10: Line 11: private static final long serialVersionUID = 3274786304152401306L; Line 12: Line 13: private int vdsNumaNodeIndex; not sure it's relevant in this context. CpuStatistics is valid also for "UMA" machines. Line 14: Line 15: private int cpuCoreId; Line 16: Line 17: private double cpuSys; Line 11: private static final long serialVersionUID = 3274786304152401306L; Line 12: Line 13: private int vdsNumaNodeIndex; Line 14: Line 15: private int cpuCoreId; use a single terminology, iirc, you used cpuIds somewhere. Line 16: Line 17: private double cpuSys; Line 18: Line 19: private double cpuUser; http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNode.java: Line 13: public abstract class NumaNode implements Serializable { Line 14: Line 15: private static final long serialVersionUID = 3751844852367478102L; Line 16: Line 17: private Guid id; id is for vmNuma node right? why in abstract? Line 18: Line 19: private int index; Line 20: Line 21: private List<Integer> cpuIds; http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 1328: Line 1329: /** Line 1330: * Numa node distance is a bivariate table which represents the distances between each host numa nodes. User may Line 1331: * need this information to decide numa configuration. Line 1332: */ ".. each .." here suggests it should reside in the numa node, and maybe can be used for VmNuma as well. IMO should be Map<Index, distance> in each node. Line 1333: public String getNumaNodeDistance() { Line 1334: return mVdsDynamic.getNumaNodeDistance(); Line 1335: } Line 1336: http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 150: private List<VdsNumaNode> numaNodeList; Line 151: Line 152: private String numaNodeDistance; Line 153: Line 154: private Boolean autoNumaBalancing; just a thought, why not using the enum? Line 155: Line 156: public void setVersion(RpmVersion value) { Line 157: rpmVersion = value; Line 158: } http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNodeStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNodeStatistics.java: Line 5: /** Line 6: * Object which represents host NUMA node statistics information Line 7: * Line 8: */ Line 9: public class VdsNumaNodeStatistics implements Serializable { should renamed to NumaNodeStatistics. the vm will also report that. Line 10: Line 11: private static final long serialVersionUID = 3274786304152401306L; Line 12: Line 13: private long memFree; http://gerrit.ovirt.org/#/c/23702/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java: Line 10: public class VmNumaNode extends NumaNode { Line 11: Line 12: private static final long serialVersionUID = -5384287037435972730L; Line 13: Line 14: private List<Integer> pinnedVdsNumaNodeList; just a quesion, if the VM has auto numa, this field will be empty? Line 15: Line 16: public VmNumaNode() { Line 17: pinnedVdsNumaNodeList = new ArrayList<Integer>(); Line 18: } -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
