Gilad Chaplik has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 13: Code-Review-1 (4 comments) Some of my comments were rejected. please see inline. http://gerrit.ovirt.org/#/c/23702/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 652: Line 653: /** Line 654: * Tracking value of VM's UTC offset. Useful for long running VMs when there can be significant drift over initial Line 655: * value computed from timeZone. Note that this value is no longer being used when starting VMs (The timeZone field Line 656: * is used to calculate that offset) and is kept in sync with value reported by VDSM only for debugging purposes. relevant to this change? please remove (all others as well) Line 657: * {@see VmInfoBuilderBase#buildVmTimeZone()} Line 658: */ Line 659: public Integer getUtcDiff() { Line 660: return this.vmDynamic.getUtcDiff(); Line 1307: public int hashCode() { Line 1308: final int prime = 31; Line 1309: int result = 1; Line 1310: long temp; Line 1311: temp = (long) _actualDiskWithSnapthotsSize; .. ^ Line 1312: result = prime * result + (int) (temp ^ (temp >>> 32)); Line 1313: result = prime * result + (balloonEnabled ? 1231 : 1237); Line 1314: result = prime * result + ((cdPath == null) ? 0 : cdPath.hashCode()); Line 1315: result = prime * result + ((configured == null) ? 0 : configured.hashCode()); http://gerrit.ovirt.org/#/c/23702/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 129: Line 130: private HashSet<Version> _supportedENGINESVersionsSet; Line 131: Line 132: /** Line 133: * This flag is set to true if the host PM can be controlled by policy. If a user triggered action puts the host to ^ Line 134: * maintenance or shuts it down, this flag is cleared. Line 135: * Line 136: * The flag should be re-set only by transitioning the host back to Up state. Line 137: * Line 638: result = prime * result + ((id == null) ? 0 : id.hashCode()); Line 639: result = Line 640: prime * result + ((_supportedClusterVersionsSet == null) ? 0 : _supportedClusterVersionsSet.hashCode()); Line 641: result = Line 642: prime * result + ((_supportedENGINESVersionsSet == null) ? 0 : _supportedENGINESVersionsSet.hashCode()); ^ I guess that this format change can be confusing, maybe that's why a reference to the added fields are missing from hashcode and equals :/ Line 643: result = prime * result + ((buildName == null) ? 0 : buildName.hashCode()); Line 644: result = prime * result + ((cpu_cores == null) ? 0 : cpu_cores.hashCode()); Line 645: result = prime * result + ((cpuThreads == null) ? 0 : cpuThreads.hashCode()); Line 646: result = prime * result + ((cpu_flags == null) ? 0 : cpu_flags.hashCode()); -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
