Alon Bar-Lev has posted comments on this change. Change subject: core: Add executePipe ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/26213/5/src/otopi/plugin.py File src/otopi/plugin.py: Line 413: 'executePipe-result: [%s] %s, rc=%s', Line 414: i, Line 415: popenKwargsList[i]['args'], Line 416: p.returncode, Line 417: ) can we do this outside the all eating exception clause VVVV Line 418: except: Line 419: self.logger.debug( Line 420: 'executePipeRaw failed: %s, exception', Line 421: popenKwargsList, Line 488: envAppend=envAppend, Line 489: delay=delay, Line 490: max_delays=max_delays, Line 491: ) Line 492: finally: if temp_name is not None Line 493: os.unlink(temp_name) Line 494: Line 495: # warning: python-2.6 does not have kwargs for decode Line 496: res = { Line 523: kw['args'], Line 524: '\n'.join(r['stderr']) Line 525: ) Line 526: failed_commands = [ Line 527: i we usually do: i for i .... :) Line 528: for i, r in enumerate(res['result']) Line 529: if r['rc'] != 0 Line 530: ] Line 531: if len(failed_commands) > 0 and raiseOnError: -- To view, visit http://gerrit.ovirt.org/26213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Gerrit-PatchSet: 5 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
