Yedidyah Bar David has posted comments on this change.

Change subject: core: Add executePipe
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26213/3/src/otopi/plugin.py
File src/otopi/plugin.py:

Line 410:                 popenKwargsList,
Line 411:                 exc_info=True
Line 412:             )
Line 413:             raise
Line 414: 
> Please explain exactly what you want here. Note that normally we do not ent
Ahh, I guess you refer to what I added above :-) (added that after posting my 
replies).
Line 415:         return {
Line 416:             'stdout': popens[-1].stdout,
Line 417:             'result': [
Line 418:                 {


-- 
To view, visit http://gerrit.ovirt.org/26213
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to