Oved Ourfali has posted comments on this change. Change subject: tools : engine-config is over writing the previous values ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/25762/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java: Line 92: int delimiterIndex = arg.indexOf("="); Line 93: if (isSetOrMergeAction() Line 94: && delimiterIndex == -1 Line 95: && !passFileExists) { Line 96: throw new IllegalArgumentException("Argument for set/concat action must be in format of key=value."); s/concat/merge Line 97: } Line 98: Line 99: String key = getStringBeforeEqualChar(arg, delimiterIndex); Line 100: String value = getStringAfterEqualChar(arg, delimiterIndex); http://gerrit.ovirt.org/#/c/25762/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java: Line 40: private final static String MERGABLE_TOKEN = "mergable"; Line 41: private final static String DELIMITER_TOKEN = "delimiter"; Line 42: private final static String MERGE_NOT_SUPPORTED_MSG = "%s does not support merge of values."; Line 43: private final static String MERGE_SAME_VALUE_MSG = "Merge operation cancelled as value is unchanged."; Line 44: private static final String MERGE_PERSIST_ERR_MSG = "setValue: error concatenating %s value. No such entry%s."; s/concatenating/merging Line 45: Line 46: private Configuration appConfig; Line 47: private HierarchicalConfiguration keysConfig; Line 48: private Map<String, String> alternateKeysMap; http://gerrit.ovirt.org/#/c/25762/4/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 380: DefaultCustomSerialNumber.type=String Line 381: UserDefinedVMProperties.mergable=true Line 382: UserDefinedVMProperties.delimiter=; Line 383: CustomDeviceProperties.mergable=true Line 384: CustomDeviceProperties.delimiter=; Two notes: 1.Just making sure, did you verify that the value in both cases is correct? 2. Put these values next to the other entry lines, and not at the bottom. -- To view, visit http://gerrit.ovirt.org/25762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
