Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Ask whether to backup the database ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26082/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py: Line 178: return ( Line 179: _('{size} MB').format(size=size_in_mb) Line 180: if size_in_mb < 1024 Line 181: else _('{size} GB').format(size=float(size_in_mb/pow(2, 10))) Line 182: ) format to display should be own function, a function called _getDBSize should return numeric. Line 183: Line 184: @plugin.event( Line 185: stage=plugin.Stages.STAGE_INIT, Line 186: ) Line 216: 'size. This process ' Line 217: 'takes time, and in some cases (for instance, when the ' Line 218: 'size is few GBs) may take few hours to complete.\n' Line 219: 'Would you like to backup the existing database before ' Line 220: 'upgrading it? ' there is no warning what will happen if not backed up, I would have even added confirmation, after yet another warning. Line 221: '(@VALUES@) [@DEFAULT@]: ' Line 222: ).format( Line 223: dbsize=self._getDBSize(), Line 224: ), -- To view, visit http://gerrit.ovirt.org/26082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
