Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26090/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 173: osetupcons.Stages.CORE_ENGINE_START, Line 174: osetupcons.Stages.APACHE_RESTART, Line 175: ), Line 176: ) Line 177: def _closeup(self): > The whole _waitEngineUp() is used only to wait for the engine to be ready b starting SDK is incorrect term. we wait for engine to be up. we use the SDK in order to access the engine. easier to perform some sanity before proceeding with logic. there is no problem in using the same instance of the api, if it is capable to survive errors. Line 178: self._waitEngineUp() Line 179: self.logger.debug('Connecting to the Engine') Line 180: engine_api = self._ovirtsdk_api.API( Line 181: url='https://{fqdn}:{port}/ovirt-engine/api'.format( -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
