Simone Tiraboschi has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26090/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 109: isUp = False Line 110: while not isUp and tries > 0: Line 111: tries -= 1 Line 112: try: Line 113: with contextlib.closing(urllib2.urlopen(api_url)) as urlObj: > always use the sdk to access the engine rest-api. I can agree with you but, at this point, see also the comment on line 178 Line 114: content = urlObj.read() Line 115: if content: Line 116: if self.PI_RE.match(content) is None: Line 117: raise RuntimeError( Line 173: osetupcons.Stages.CORE_ENGINE_START, Line 174: osetupcons.Stages.APACHE_RESTART, Line 175: ), Line 176: ) Line 177: def _closeup(self): The whole _waitEngineUp() is used only to wait for the engine to be ready before starting the SDK; if I rely on SDK exceptions to check the engine status I can just wait here throwing away the _waitEngineUp() Line 178: self._waitEngineUp() Line 179: self.logger.debug('Connecting to the Engine') Line 180: engine_api = self._ovirtsdk_api.API( Line 181: url='https://{fqdn}:{port}/ovirt-engine/api'.format( -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
