Shireesh Anjal has posted comments on this change.
Change subject: restapi: Gluster Brick resource implementation
......................................................................
Patch Set 2: (2 inline comments)
Responses to inline comments.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 174: <xs:element name="new_brick" type="GlusterBrick" minOccurs="0"/>
The replace brick api is an action on an existing brick, and the action
parameter will represent the new brick that will replace the existing one. So I
thought "new_brick" sounds intuitive. I don't mind changing it to just a brick
if you think that's more appropriate.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 2210: - mandatoryArguments: {action.new_brick.server_id:
'xs:string', action.new_brick.brick_dir: 'xs:string'}
A "host" is more appropriate in "virtualization" context as it "hosts" the
virtual machines. In Gluster storage context, they are just "storage servers".
So even though the underlying object / table is same as the ovirt host, we
would call it as "server" in the Gluster context.
--
To view, visit http://gerrit.ovirt.org/4786
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If46e67bf574d48d615c33096b36f8c02a267bd3f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
