Michael Pasternak has posted comments on this change.
Change subject: restapi: Gluster Brick resource implementation
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 174: <xs:element name="new_brick" type="GlusterBrick" minOccurs="0"/>
why not just a brick?
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 2210: - mandatoryArguments: {action.new_brick.server_id:
'xs:string', action.new_brick.brick_dir: 'xs:string'}
the /server/ is storage serv. or host? if ovirt host, i prefer calling it
host_id - this is naming convention across the app.
--
To view, visit http://gerrit.ovirt.org/4786
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If46e67bf574d48d615c33096b36f8c02a267bd3f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
