Oved Ourfali has posted comments on this change. Change subject: ux: allow using password authentication on foreman hosts ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25965/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 1684: getConsoleAddress().setIsChangable(consoleAddressEnabled); Line 1685: Line 1686: if (!showInstallationProperties()) { Line 1687: getPkSection().setIsChangable(false); Line 1688: getPkSection().setIsAvailable(false); > so why not doing that as in getOverrideIpTables() Indeed harder to follow. The name comes to denote whether we are in "installation" or not, so it is good in that case I guess. We will need to revisit this code anyway as part of the Foreman integration, to support the approval well, so let's handle it then. Line 1689: Line 1690: // Use public key when edit or approve host Line 1691: setAuthenticationMethod(AuthenticationMethod.PublicKey); Line 1692: } -- To view, visit http://gerrit.ovirt.org/25965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
