Yaniv Bronhaim has posted comments on this change. Change subject: ux: allow using password authentication on foreman hosts ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25965/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 1688: false so why not doing that as in getOverrideIpTables() getPkSection().setIsChangable(showInstallationProperties()) .. same for : setAuthenticationMethod(showInstallationProperties() ? AuthenticationMethod.Password : AuthenticationMethod.PublicKey) or if its hard to follow, lets separate to 2 sections, and better function name (than showInstallationProperties) that determines if we're adding new host or edit one -- To view, visit http://gerrit.ovirt.org/25965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
