Greg Padgett has posted comments on this change. Change subject: Add metadata storage support for raw block device ......................................................................
Patch Set 13: Code-Review+1 (1 comment) Looks good, one possibility in the comments but it's optional. http://gerrit.ovirt.org/#/c/25798/13//COMMIT_MSG Commit Message: Line 22: 64 bytes with service name (first byte equals the used length) Line 23: 8B + 8B pointers to data section (start block, length) Line 24: ... more data sections if needed Line 25: 16B of 0 acting as a sentinel Line 26: 4B CRC32 checksum The unused 4B could be magic or a version id, but I don't think this is required to be able to discover the format in the future if needed. Line 27: Line 28: If there is need to use lots of data sections for a single service, Line 29: is is possible tp use the service name multiple times and the data Line 30: blocks will be concatenated using device mapper. -- To view, visit http://gerrit.ovirt.org/25798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ab21fb2075fc59b444b5754ade8a1569b83b18 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
