Martin Sivák has posted comments on this change. Change subject: Add metadata storage support for raw block device ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/25798/11/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 6: import re Line 7: from collections import namedtuple Line 8: import zlib Line 9: import struct Line 10: from cStringIO import StringIO > ^^ above doesn't work on python3. I suggest to use io.BytesIO instead Done Line 11: from operator import itemgetter Line 12: import math Line 13: Line 14: logger = logging.getLogger(__name__) http://gerrit.ovirt.org/#/c/25798/11/ovirt_hosted_engine_ha/lib/storage_backends_test.py File ovirt_hosted_engine_ha/lib/storage_backends_test.py: Line 1: import unittest Line 2: import cStringIO as StringIO > please us io.BytesIO Done Line 3: import struct Line 4: import zlib Line 5: Line 6: from .storage_backends import BlockBackend -- To view, visit http://gerrit.ovirt.org/25798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ab21fb2075fc59b444b5754ade8a1569b83b18 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
