Federico Simoncelli has posted comments on this change. Change subject: engine: Send ifaceName and tpgt in connectStorageServer ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25890/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java: Line 72: // for information, see _connectionDict2ConnectionInfo in vdsm/storage/hsm.py Line 73: DefaultValueMap con = new DefaultValueMap(); Line 74: con.put("id", connection.getid(), Guid.Empty.toString()); Line 75: con.put("connection", connection.getconnection(), ""); Line 76: con.put("tpgt", connection.getportal(), ""); Are you sure this is backward compatible? Should you send both? (e.g. for old vdsm) Line 77: con.put("port", connection.getport(), ""); Line 78: con.put("iqn", connection.getiqn(), ""); Line 79: con.put("user", connection.getuser_name(), ""); Line 80: con.put("password", connection.getpassword(), ""); -- To view, visit http://gerrit.ovirt.org/25890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
