Alon Bar-Lev has posted comments on this change. Change subject: wip: remove the use of @LockIdNameAttribute ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25944/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1750: * Commands that need exclusive locks will over ride this method Line 1751: * to provide custom locking property settings Line 1752: */ Line 1753: protected LockProperties getLockingPropertiesSettings() { Line 1754: return new LockProperties().setObtainLock(false); I expect this should be false by default... return new LockProperties(); And if you want to lock you: return new LockProperties.setObtainLock(true); Line 1755: } Line 1756: Line 1757: protected LockProperties getLockProperties() { Line 1758: LockProperties lockProperties = _parameters.getLockProperties(); -- To view, visit http://gerrit.ovirt.org/25944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie57e4f7c00ebcd6a4e9e0e61b7d26f50f2d00858 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
