Ravi Nori has posted comments on this change. Change subject: wip: remove the use of @LockIdNameAttribute ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25944/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1747: Line 1748: protected LockProperties getLockProperties() { Line 1749: return LockProperties.build(getClass().getAnnotation(LockIdNameAttribute.class)); Line 1750: } Line 1751: The above method looks for LockIdNameAttribute, is for transition purpose. Once LockIdNameAttribute is removed this will return null. Commands need to override getLockProperties to return the lockProperties. Line 1752: protected boolean acquireLock() { Line 1753: LockProperties lockProperties = getLockProperties(); Line 1754: boolean returnValue = true; Line 1755: if (lockProperties != null) { -- To view, visit http://gerrit.ovirt.org/25944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie57e4f7c00ebcd6a4e9e0e61b7d26f50f2d00858 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
