Einav Cohen has posted comments on this change.

Change subject: core, engine, webadmin: Shutdown/power off operations on a VM 
would ask for an optional reason
......................................................................


Patch Set 11:

Gilad, I like the idea, bug again - my only concern is that, unlike the other 
'notes', the shutdown reason 'note' needs to be non-editable and needs to be 
removed automatically once the VM was started; so we need to mark that 
particular 'note' in a special manner, and I am not sure how exactly to do 
that. We can probably format the string (that contains the overall 'notes' 
data) in a special pattern to support that or something similar - so need to 
think about that a bit.

-- 
To view, visit http://gerrit.ovirt.org/25633
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to