Gilad Chaplik has posted comments on this change. Change subject: core, engine, webadmin: Shutdown/power off operations on a VM would ask for an optional reason ......................................................................
Patch Set 11: hi Einav, and thanks for very quick and quick reply. I totally agree with you, that's why I suggest a slightly different and simple approach: Currently the comment field is text-> meant to be a single comment. I suggest to alter it to Notes (LOL a new feature) (btw, even the yellow icon looks like post-its (in plural) = notes). we can use the current text field for multiple note, with a snap of our fingers. The only problem with that is the visualization of notes in the vm/other entity dialog. maybe we can brainstorm on it a bit and come up with a better and complete solution. >From the top of my head, we can use custom properties sheet, with limited >height (we don't want to bother other fields in the dialog), and add an RFE to >enhance the visualization of the new notes/old comment feature (sth like >drag-able post-its on top of the dialog). the column has no problem dealing >with xml/json so we're safe there, also db upgrade is easy, wrap a single/no >comment into xml/json. I hope I wasn't too unclear Thanks, Gilad. -- To view, visit http://gerrit.ovirt.org/25633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
