Yaniv Bronhaim has posted comments on this change. Change subject: webadmin: Add boot time to Host General tab ......................................................................
Patch Set 4: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/25879/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeTimezoneRenderer.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeTimezoneRenderer.java: Line 29: Line 30: public static DateTimeFormat getLocalizedDateTimeFormat() { Line 31: if (LocaleInfo.getCurrentLocale().getLocaleName().startsWith(japaneseLocale)) { Line 32: return formatJp; Line 33: } the Japanese format is the same, why do you need it? Line 34: return format; Line 35: } Line 36: http://gerrit.ovirt.org/#/c/25879/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/FullDateTimeTimezoneLabel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/FullDateTimeTimezoneLabel.java: Line 8: FullDateTimeTimezoneLabel isn't UptimeRenderer enough for that purpose ? -- To view, visit http://gerrit.ovirt.org/25879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157042522209f5917bcdd951b9259f08cabbd907 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
