Daniel Erez has posted comments on this change. Change subject: webadmin: Add boot time to Host General tab ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25879/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeTimezoneRenderer.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeTimezoneRenderer.java: Line 6: * Renderer for Date values using {@code FullDateTimeFormat}. Line 7: */ Line 8: public class FullDateTimeTimezoneRenderer extends FullDateTimeRenderer { Line 9: Line 10: private static final DateTimeFormat formatJp = DateTimeFormat.getFormat("yyyy-MM-dd, HH:mm z"); //$NON-NLS-1$ Just a suggestion - since the only addition to the format string is the character 'z', Instead of introducing these new constants and methods, I think it might be cleaner to just append it to the current format. I.e. add/reuse a method that appends the character to the given format - preferably in some generic static manner. Let me know if it's too complex with the current design... Line 11: private static final DateTimeFormat format = DateTimeFormat.getFormat("yyyy-MMM-dd, HH:mm z"); //$NON-NLS-1$ Line 12: Line 13: protected static DateTimeFormat getFormat() { Line 14: return format; -- To view, visit http://gerrit.ovirt.org/25879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157042522209f5917bcdd951b9259f08cabbd907 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
