Omer Frenkel has posted comments on this change.

Change subject: core: Added uptime for the VDS entity
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/25832/4/backend/manager/modules/dal/src/test/resources/fixtures.xml
File backend/manager/modules/dal/src/test/resources/fixtures.xml:

Line 2931:             <value>false</value>
Line 2932:             <value>false</value>
Line 2933:             <value>false</value>
Line 2934:             <value>false</value>
Line 2935:             <value>666</value>
it would worth putting one with null just to have some diversity in results
Line 2936:         </row>
Line 2937:     </table>
Line 2938: 
Line 2939:     <table name="vm_dynamic">


-- 
To view, visit http://gerrit.ovirt.org/25832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0bb08690718e9b6b6a8474d2f6be5f2e9eeeda
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to