Tal Nisan has posted comments on this change.

Change subject: core: Added uptime for the VDS entity
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25832/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java:

Line 122:                 && (anonymousHugePages == other.anonymousHugePages)
Line 123:                 && (highlyAvailableScore == 
other.highlyAvailableScore)
Line 124:                 && (highlyAvailableIsConfigured == 
other.highlyAvailableIsConfigured)
Line 125:                 && (highlyAvailableIsActive == 
other.highlyAvailableIsActive)
Line 126:                 && (highlyAvailableGlobalMaintenance == 
other.highlyAvailableGlobalMaintenance)
> If you add the uptime in the hashCode, in MUST also be a part of the equals
Obviously, must have slipped my mind
Line 127:                 && (highlyAvailableLocalMaintenance == 
other.highlyAvailableLocalMaintenance));
Line 128:     }
Line 129: 
Line 130:     public Double getcpu_idle() {


-- 
To view, visit http://gerrit.ovirt.org/25832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0bb08690718e9b6b6a8474d2f6be5f2e9eeeda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to