Michael Pasternak has posted comments on this change.
Change subject: restapi: Support Floating Disks
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
Line 193
i'm not talking about Disk, but about having another map of:
map = new ParentToCollectionMap(DeviceResource.class, DevicesResource.class,
VM.class);
that you deleted
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskResource.java
Line 16
oh, you so kind! :)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
Line 35: public interface VmDiskResource extends DeviceResource<Disk>,
MeasurableResource {
the signatures are same, unless it some kind of complicated resteasy issue,
i'd prefer extending known interface rather than rewriting it again
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 251: headers: {}
make single signature with Action type and two overloads of parameters for it:
1. with action.detach
2. without action.detach
because of if(action.isSetDetach()) in java code - it will always work.
Line 285: - mandatoryArguments: {disk.id: 'xs:string'}
correct
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 63: if (action.isDetach()) {
having such implementation will not allow us overriding signatures
for delete, see my comment in yaml to understand.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java
Line 43: disk.setVm(new VM());
what is the reason for having empty <vm/> element inside of the disk?,
--
To view, visit http://gerrit.ovirt.org/4665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314ba532b1a40286053f87bb4f0f3c90b5850b5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
