Ori Liel has posted comments on this change.
Change subject: restapi: Support Floating Disks
......................................................................
Patch Set 2: (9 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
Line 193
the next line does this again:
TYPES.put(Disk.class, map);
TYPES is a simple wrapper of a map. Running 'put()' again with the same key
overrides the previous value. So the line that I deleted was immediately
overridden anyway.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskResource.java
Line 16
Because it's mine... MINE!!!
Ok, I'll put it back.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
Line 35: public interface VmDiskResource extends DeviceResource<Disk>,
MeasurableResource {
I initially wanted to do this, there was something that changed my mind but I
can't remember what it was. If you insiste - I'll re-do the change until I run
into the same thing. Do you insist? :)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 251: headers: {}
Because paramter-type is not a part of signature, it's above it, and here we
have a signature in which it's 'null' and a signature in which it's 'action'.
Line 285: - mandatoryArguments: {disk.id: 'xs:string'}
It's a different signature. Look above, there's another signature (the
signature which existed so far), in which it's not mandatory
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
Line 75: return super.get();//explicit call solves REST-Easy confusion
will do.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 63: if (action.isDetach()) {
Look above: validateParameters(action, "detach");
Line 64: AttachDettachVmDiskParameters params = new
AttachDettachVmDiskParameters(parentId, Guid.createGuidFromString(id), true);
ok
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java
Line 43: disk.setVm(new VM());
it should because this disk might be floating, and in that case it won't have a
VM associated with it --> NPE
--
To view, visit http://gerrit.ovirt.org/4665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314ba532b1a40286053f87bb4f0f3c90b5850b5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
