Lior Vernia has posted comments on this change. Change subject: webadmin: Overload ListModel.setItems() with selectedItem ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25651/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java: Line 254: } else { Line 255: List<T> selectedItems = new ArrayList<T>(); Line 256: selectedItems.add(selectedItem); Line 257: setSelectedItem(selectedItem); Line 258: setSelectedItems(selectedItems); > my question is how the user control sets the selected item, before the item Even before this patch, the user was already setting the selected item before the items event was triggered. As part of setItems(), setSelectedItem(null) was being called before the ItemsChangedEvent was raised. This overload should give some control over the value to which selectedItem will be set, but I haven't touched the order of events. Does this answer the question, or did I misunderstand again? :) Line 259: } Line 260: } Line 261: Line 262: protected void itemsChanged() -- To view, visit http://gerrit.ovirt.org/25651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6de644297cdd5eb965720fc64aea1a5a735ea24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
