Lior Vernia has posted comments on this change. Change subject: webadmin: Overload ListModel.setItems() with selectedItem ......................................................................
Patch Set 1: Thanks Vojtech! You made a good point, and I've considered, but I think I prefer push it as is. The thing is, if someone overrides itemsChanged(selectedItem) without calling the super implementation, they'll probably be trying to avoid the default behavior, in which case it would be more convenient to have to override just one method instead of two. In addition, the same argument could have been made for the new overload of setItems() - overriding it without calling the super implementation would also affect the default behavior. That is inevitable however, and these methods are generally "risky" to override - we have to presume overriding them is being done in a responsible manner. -- To view, visit http://gerrit.ovirt.org/25651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6de644297cdd5eb965720fc64aea1a5a735ea24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
