Ravi Nori has posted comments on this change. Change subject: engine, webadmin: Re-work engine ovirt-node host-deploy sequence ......................................................................
Patch Set 2: @Alon This is how we initially had the code. Webadmin invokes UpdateVds, UpdateVds performs various checks and then calls VdcActionType.InstallVds. InstallVds had the code for both Vds install and oVirtNode updgrade. In this patch Webadmin invokes UpdateVds and UpdateOvirtNode to handle vds and host separately. UpdateVdsCommand and UpdateOvirtNodeCommand extend UpdateVdsCommandBase as they reuse most of the code. UpdateVdsCommand invokes InstallVdsCommand and UpdateOvirtNodeCommand invokes UpgradeOvirtNodeCommand. Both InstallVdsCommand and UpgradeOvirtNodeCommand extend InstallVdsCommandBase as many of the functions can be reused. -- To view, visit http://gerrit.ovirt.org/25685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches