Alon Bar-Lev has posted comments on this change.

Change subject: engine, webadmin: Re-work engine ovirt-node host-deploy sequence
......................................................................


Patch Set 2:

(1 comment)

Thanks!!!

I am not that know the commands mechanism... but I expect only two commands:

1. install - which is install/reinstall as we use the same sequence.

2. upgrade node

Why do we need these:

 UpdateVdsCommand
 UpdateVdsCommandBase
 UpdateOvirtNodeCommand -> we have UpgraddeOvirtNodeCommand

Thanks!

http://gerrit.ovirt.org/#/c/25685/2//COMMIT_MSG
Commit Message:

Line 9: The current host delpy sequence does not let the oVirt node to be 
Line 10: redeployed, it can only be upgrdaed.
Line 11: 
Line 12: Split the back end UpdateVds into two commands, UpdateVds and 
Line 13: UpdateOvirtNode. UpdateVds invokes InstallVds to redeploy host and
spaces
Line 14: UpdateOvirtNode invokes UpgradeOvirtNode to upgrade oVirtNode.
Line 15: 
Line 16: Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787
Line 17: Bug-Url: https://bugzilla.redhat.com/989546


-- 
To view, visit http://gerrit.ovirt.org/25685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to