Yair Zaslavsky has posted comments on this change. Change subject: aaa: removing bll imports and dependencies ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25604/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/KerberosManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/KerberosManager.java: Line 48: * This method is called upon the bean creation as part Line 49: * of the management Service bean lifecycle. Line 50: */ Line 51: public void create() { Line 52: if (!isKerberosAuth()) { Move all of this code to the CTOR, and remove the create method. Line 53: return; Line 54: } Line 55: String engineEtc = System.getenv("ENGINE_ETC"); Line 56: if (engineEtc == null) { -- To view, visit http://gerrit.ovirt.org/25604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib52e923b373d2a8bcbda72d73e69a3d7d75e527e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
