Alon Bar-Lev has posted comments on this change. Change subject: aaa: removing bll imports and dependencies ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25604/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 183: profileName); Line 184: AuditLogType auditLogType = auditLogMap.get(ex.getError()); Line 185: //if found matching audit log type, and it's not general login failure audit log (which will be logged anyway due to CommandBase.log) Line 186: if (auditLogType != null && auditLogType != AuditLogType.USER_VDC_LOGIN_FAILED) { Line 187: logEventForUser(loginName, auditLogType); in future this should go to the accounting extension... remember? aaa = authentication, authorization and accounting. we will need to delegate: login logout change password fail login etc... not important now. Line 188: } Line 189: Line 190: VdcBllMessages canDoActionMsg = vdcBllMessagesMap.get(ex.getError()); Line 191: http://gerrit.ovirt.org/#/c/25604/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/KerberosManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/KerberosManager.java: Line 69: System.setProperty("sun.security.krb5.msinterop.kstring", "true"); Line 70: } Line 71: Line 72: private KerberosManager() { Line 73: create(); you can move the create into constructor, no? why create is left public? Line 74: } Line 75: -- To view, visit http://gerrit.ovirt.org/25604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib52e923b373d2a8bcbda72d73e69a3d7d75e527e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
