Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Removal of old Internal broker
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/25594/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java:

Line 63:     public void create() {
Line 64: 
Line 65:         // Create authentication profiles for all the domains that 
exist in the database:
Line 66:         // TODO: remove this later, and rely only on the custom and 
built in extensions directories configuration
Line 67:         InternalAuthenticator internalAuthenticator = new 
InternalAuthenticator();
All this code will be moved after modularization to ExtensionsManager - we will 
give it a method to get legacy/built in properties objects from the vdc_options 
table (for internal , and each one of the current  ldap domains)
Line 68:         Map<ExtensionProperties, Object> internalAuthContext = new 
EnumMap<>(ExtensionProperties.class);
Line 69:         Properties internalAuthProps = new Properties();
Line 70:         String internalProfileName = Config.<String> 
getValue(ConfigValues.AdminDomain).trim();
Line 71:         internalAuthProps.put("ovirt.engine.aaa.authn.profile.name", 
internalProfileName);


-- 
To view, visit http://gerrit.ovirt.org/25594
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe72ff0fcdac425a28646d9850cc56cc0a7c058
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to