Martin Peřina has posted comments on this change. Change subject: aaa: InternalAuthenticatorUserCommand should throw exception ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25594/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalAuthenticateUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalAuthenticateUserCommand.java: Line 45: setReturnValue(result); Line 46: } Line 47: if (!result.isSuccessful()) { Line 48: throw new AAAExtensionException(AAAExtensionError.INCORRECT_CREDENTIALS, ""); Line 49: } I would move this block to line 37, so the exception is thrown asap. Line 50: } Line 51: -- To view, visit http://gerrit.ovirt.org/25594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fe72ff0fcdac425a28646d9850cc56cc0a7c058 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
