Michael Pasternak has posted comments on this change. Change subject: codegen: Overload methods for new headers ......................................................................
Patch Set 2: sure, you're right & i'm perfectly fine with having two standalone patches, but reviewing codegen changes (especially when the change ain't trivial) it's nearly impossible to see the impacts it has on the actual code, also if one have comments and you fix them, you/he can't see the effect it has. thus i think generated code should be the following patch (that depends on the codegen changes) and both submitted for review under the same context. thanks. -- To view, visit http://gerrit.ovirt.org/25521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c035983a6f74aec7dd611f2aaa4ba1d1581594e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
