Michael Pasternak has posted comments on this change. Change subject: codegen: Overload methods for new headers ......................................................................
Patch Set 2: Juan, In such a big change is quite hard to see all impacts it has, please run code-gen using this change and make it apart of this change or next one that depends on it. also in future please don't mix changes that came from codegen with rebase-against-api, as it hard to review/debug and locate regressions (if it creates), (as for me, i prefer having all in a same patch, both codegen changes and code it produce, - this way it always in a same context making a reviewer life a bit easier) -- To view, visit http://gerrit.ovirt.org/25521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c035983a6f74aec7dd611f2aaa4ba1d1581594e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches