Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Intrdoucing of ExtensionException
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25507/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java
File 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java:

Line 33:      *
Line 34:      * @param name the name of the user
Line 35:      * @return the user corresponding to the given name or {@code 
null} if no such user can be found
Line 36:      */
Line 37:     public abstract DirectoryUser findUser(String name) throws 
ExtensionException;
> please make it RuntimeException and drop these
Done
Line 38: 
Line 39:     /**
Line 40:      * Retrieves a user from the directory given its identifier.
Line 41:      *


-- 
To view, visit http://gerrit.ovirt.org/25507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5cb41bf103c6345e501a81cbe247dc53051d0db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to