Alon Bar-Lev has posted comments on this change. Change subject: aaa: Intrdoucing of ExtensionException ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25507/2/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionException.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionException.java: Line 1: package org.ovirt.engine.core.extensions.mgr; Line 2: Line 3: public class ExtensionException extends RuntimeException { > if it already extends RuntimeException, why have you added it to all protot Most important! This is AAAExtension not generic ExtensionException. And as we agreed, we remove it in future in favour of plain result. Line 4: Line 5: Line 6: public enum ExtensionError { INCORRET_CREDENTIALS, Line 7: CREDENTIALS_EXPIRED, -- To view, visit http://gerrit.ovirt.org/25507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5cb41bf103c6345e501a81cbe247dc53051d0db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
