Omer Frenkel has posted comments on this change. Change subject: engine: RFE: set locale language and keyboard via Sysprep ......................................................................
Patch Set 7: (2 comments) looks ok, 2 minor comments http://gerrit.ovirt.org/#/c/24838/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java: Line 27: private String uiLanguage; Line 28: private String systemLocale; Line 29: private String userLocale; Line 30: Line 31: public static final String DEFALUT_LOCALE = "en_US"; please make this configurable (something like defaultSysprepLocale) Line 32: Line 33: public VmInit() { Line 34: inputLocale = DEFALUT_LOCALE; Line 35: uiLanguage = DEFALUT_LOCALE; http://gerrit.ovirt.org/#/c/24838/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java: Line 71: .addValue("custom_script", vmInit.getCustomScript()) Line 72: .addValue("input_locale", vmInit.getInputLocale()) Line 73: .addValue("ui_language", vmInit.getUiLanguage()) Line 74: .addValue("system_locale", vmInit.getSystemLocale()) Line 75: .addValue("user_locale", vmInit.getUserLocale()); please update fixtures.xml with new columns Line 76: } Line 77: Line 78: private static class VMInitRowMapper implements RowMapper<VmInit> { Line 79: public static final VMInitRowMapper instance = new VMInitRowMapper(); -- To view, visit http://gerrit.ovirt.org/24838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica4e2edf34a49c907ba32fa0a14bf6a4e4527cf4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
