Shahar Havivi has posted comments on this change.

Change subject: engine: RFE: set locale language and keyboard via Sysprep
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/24838/5/packaging/dbscripts/upgrade/03_05_0060_vm_init_add_sysprep_locale.sql
File packaging/dbscripts/upgrade/03_05_0060_vm_init_add_sysprep_locale.sql:

Line 1: -- 
----------------------------------------------------------------------
Line 2: -- Adding setup language options for Windows Sysprep
> Script needs renaming , there is already 03_05_0060
Done
Line 3: -- 
----------------------------------------------------------------------
Line 4: alter table vm_init add column setup_ui_language_ui_language 
VARCHAR(256) DEFAULT NULL;
Line 5: alter table vm_init add column input_locale VARCHAR(256) DEFAULT NULL;
Line 6: alter table vm_init add column ui_language VARCHAR(256) DEFAULT NULL;


Line 5: alter table vm_init add column input_locale VARCHAR(256) DEFAULT NULL;
Line 6: alter table vm_init add column ui_language VARCHAR(256) DEFAULT NULL;
Line 7: alter table vm_init add column system_locale VARCHAR(256) DEFAULT NULL;
Line 8: alter table vm_init add column user_locale VARCHAR(256) DEFAULT NULL;
Line 9: alter table vm_init add column ui_language_fallback VARCHAR(256) 
DEFAULT NULL;
> No need for separate statements , can be done in 1 as follows :
Done


-- 
To view, visit http://gerrit.ovirt.org/24838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica4e2edf34a49c907ba32fa0a14bf6a4e4527cf4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to