Lior Vernia has posted comments on this change. Change subject: webadmin: [Labels] SetupNetwork emphasize unconfigured interface ......................................................................
Patch Set 9: Code-Review+2 (2 comments) Note comments. http://gerrit.ovirt.org/#/c/24975/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 791: NetworkInterfaceModel desiredNic = nicModels.get(labelToIface.get(networkModel.getEntity().getLabel())); Line 792: NetworkOperation operation = NetworkOperationFactory.operationFor(networkModel, desiredNic); Line 793: UIMessages messages = ConstantsManager.getInstance().getMessages(); Line 794: // Should be attached but can't due to conflict Line 795: if (operation.isNullOperation()) { Consider using the ?: operator inside networkModel.setErrorMessage(). Line 796: networkModel.setErrorMessage(messages.networkLabelConflict(desiredNic.getName(), Line 797: networkModel.getEntity().getLabel()) Line 798: + " " + operation.getMessage(networkModel, desiredNic)); //$NON-NLS-1$ Line 799: } else { Line 796: networkModel.setErrorMessage(messages.networkLabelConflict(desiredNic.getName(), Line 797: networkModel.getEntity().getLabel()) Line 798: + " " + operation.getMessage(networkModel, desiredNic)); //$NON-NLS-1$ Line 799: } else { Line 800: networkModel.setErrorMessage(messages.labledNetworkNotAttached(desiredNic.getName(), Typo in constant name, it's supposed to be "labeled"/"labelled", depending whether one is British or American. Line 801: networkModel.getEntity().getLabel())); Line 802: } Line 803: } Line 804: } -- To view, visit http://gerrit.ovirt.org/24975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa83ddfd2ceddc8f2227dcc8cc36c721baf8c7bc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
