Lior Vernia has posted comments on this change. Change subject: webadmin: [Labels] SetupNetwork emphasize unconfigured interface ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/24975/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java: Line 91: Line 92: rowPanel.setWidget(0, 0, dragImage); Line 93: Line 94: Panel statusPanel = new HorizontalPanel(); Line 95: rowPanel.setWidget(0, 1, statusPanel); > It looks strange if the exclamation mark image is after the network name... How about adding another widget spot for the exclamation mark, and have it populated by default with some empty image that takes up the same amount of space as the exclamation mark image? This way, it'll always appear as the first thing, but won't harm any alignment. It shouldn't take up a lot of space, as the exclamation mark is thin, therefore the image could also be made thin (if it isn't already). Line 96: if (alertImage != null) { Line 97: statusPanel.add(alertImage); Line 98: } Line 99: -- To view, visit http://gerrit.ovirt.org/24975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa83ddfd2ceddc8f2227dcc8cc36c721baf8c7bc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
