Liron Ar has posted comments on this change. Change subject: core: Remove usage of dynamic queries from the Backend ......................................................................
Patch Set 13: (3 comments) http://gerrit.ovirt.org/#/c/24310/13/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java: Line 205: } Line 206: Line 207: @Override Line 208: public StorageDomain getByName(String name, Guid userID, boolean isFiltered) { Line 209: return getCallsHandler().executeRead("Getstorage_domains_By_name", 1. name should be changed here to 'by'. 2. see related comment in previous patch, seems like we can use the existing method of storagedomainstatic. Line 210: StorageDomainRowMapper.instance, Line 211: getCustomMapSqlParameterSource() Line 212: .addValue("name", name) Line 213: .addValue("user_id", userID) http://gerrit.ovirt.org/#/c/24310/13/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java: Line 173: } Line 174: return collection; Line 175: } Line 176: Line 177: private Guid getClusterId(Host host) { you forgot the change this method, see related comment in previous patchset. Line 178: String name = host.isSetCluster() && host.getCluster().isSetName() Line 179: ? host.getCluster().getName() Line 180: : "Default"; Line 181: return host.isSetCluster() && host.getCluster().isSetId() http://gerrit.ovirt.org/#/c/24310/13/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java: Line 66: setUriInfo(setUpBasicUriExpectations()); Line 67: Line 68: setUpEntityQueryExpectations(VdcQueryType.GetAllDbUsers, Line 69: VdcQueryParametersBase.class, Line 70: new String[] {}, related comment in previous patch Line 71: new Object[] {}, Line 72: getUsers()); Line 73: Line 74: setUpGetEntityExpectations(); -- To view, visit http://gerrit.ovirt.org/24310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3df981a958fae36edd6ecf3cb2bb47b94b2c446a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
