Ramesh N has posted comments on this change. Change subject: <WIP>engine: support for external event handlers ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/25270/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java: Line 63: Line 64: protected void processExternalEventHandlers(AuditLog event) { Line 65: Set<ExternalEventHandler> eventHandlers = Line 66: ExternalEventHandlerProvider.getInstance().getEventHandlers(event.getExternalEventType()); Line 67: for (ExternalEventHandler eventHandler : eventHandlers) { > You can inline the temp variable. You mean the eventHandlers variable ? Line 68: if (eventHandler.canHandleEvent(event)) { Line 69: eventHandler.handleEvent(event); Line 70: } Line 71: } http://gerrit.ovirt.org/#/c/25270/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/events/ExternalEventHandlerProvider.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/events/ExternalEventHandlerProvider.java: Line 19: registerExternalEventHandler(ExternalEventType.GLUSTER_VOLUME_STARTED, new GlusterVolumeStartedEventHandler()); Line 20: } Line 21: Line 22: private void registerExternalEventHandler(ExternalEventType eventType, ExternalEventHandler eventHandler) { Line 23: Set<ExternalEventHandler> eventHandlers = externalEventHandlers.get(eventType); > If you look at utils we have a utility for map with multiple values. Done Line 24: if (eventHandlers == null || eventHandlers.isEmpty()) { Line 25: eventHandlers = new HashSet<ExternalEventHandler>(); Line 26: externalEventHandlers.put(eventType, eventHandlers); Line 27: } http://gerrit.ovirt.org/#/c/25270/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java: Line 140: if (event.isSetCustomData()) { Line 141: auditLog.setCustomData(event.getCustomData()); Line 142: } Line 143: Line 144: if (event.isSetExternalEventCode()) { > shouldn't this also be checked at restpai tests? Yes. We have to write test cases. I am working on it. Line 145: auditLog.setExternalEventType(ExternalEventType.forValue(event.getExternalEventCode())); Line 146: } Line 147: Line 148: if(event.isSetParams()){ -- To view, visit http://gerrit.ovirt.org/25270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9c8638fbc8794cc196134093af9ff7e7cb4876 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
